Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave saving .ova files with .ovf file extension. #4413

Open
darrenmartyn opened this issue May 13, 2019 · 5 comments
Open

Brave saving .ova files with .ovf file extension. #4413

darrenmartyn opened this issue May 13, 2019 · 5 comments
Assignees
Labels
feature/download needs-investigation A bug not 100% confirmed/fixed

Comments

@darrenmartyn
Copy link

darrenmartyn commented May 13, 2019

Description

Downloading .ova files results in a .ovf file being saved. These two extensions are handled differently by virtualization software, so this is obviously not a good thing.

Steps to Reproduce

  1. Try download a file with the ".ova" extension.
  2. Notice it gets somehow renamed to ".ovf"
  3. Example file: https://s3-us-west-2.amazonaws.com/hyperiongray-public/whobuntu-0.0.1alpha.ova

Actual result:

A .ovf file is saved.

Expected result:

A .ova file should be saved.

Reproduces how often:

Reproduces every time with the image I was attempting to download. Not really sure why it is happening either...

Brave version (brave://version info)

Brave | 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision | 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS | Mac OS X
JavaScript | V8 7.4.288.26

Other Additional Information:

Not reproducible on Chrome, have not the bandwidth to download more large .ova files at this time to test variants.

Can also be reproduced with: https://sourceforge.net/projects/virtualappliances/files/

@rebron
Copy link
Collaborator

rebron commented May 24, 2019

cc: @srirambv to investigate more

@rebron rebron added the needs-investigation A bug not 100% confirmed/fixed label May 31, 2019
@srirambv
Copy link
Contributor

srirambv commented Jun 12, 2019

The file is still being saved as .ova but macOS is associating it as OVF format because of the virtualisation software that is installed on macOS like VMWare Fusion. Here's the screenshots
With VMWare installed there is a default file association that is happening. Its the same with Chrome and Brave
Screenshot 2019-06-12 at 8 14 25 AM
File name is still .ova but the kind of file association is OVF
Screenshot 2019-06-12 at 8 13 50 AM

@rtkypoeluev
Copy link

rtkypoeluev commented Apr 21, 2021

Hello there, if you try to do it again with AWS S3, Brave will save OVA file as ".OVF" file. There is a dependency on AWS S3 responses somehow. I would ask to investigate this further, by replicating the problem with Brave and AWS S3.

I would recommend comparing the responses from AWS S3 location and responses from https://sourceforge.net/projects/virtualappliances/files/. Maybe you will be able to spot the differences and hopefully provide a fix to Brave.

Thanks

@rtkypoeluev
Copy link

rtkypoeluev commented Apr 21, 2021

Hello again, I came across a similar issue on Firefox, https://bugzilla.mozilla.org/show_bug.cgi?id=1369576, which has been fixed on that browser. Hopefully this will help to expedite the fix on Brave. Thanks

@rtkypoeluev
Copy link

rtkypoeluev commented Apr 22, 2021

More details on the issue, according to my results these are important points for reproducing it:

  • Brave browser connecting to AWS S3 for OVA download
  • "Content-Disposition" used in the request with "attachment; "+filename+".ova" (usually different from the file stored in S3, this is essential in reproducing!) specified in the "Content-Disposition", where "Content-Type" is defined as "application/gzip", "binary/octet-stream", others (with no effect)

It appears that Brave doesn't set/use the filename passed in the request/response for saving it correctly as ".ova", but rather uses the virtualization file extensions set in the OS (e.g. MacOS).

Workaround: The workaround at this points (until the fix is implemented in Brave) is to not specify filename in the "Content-Disposition", in which case the file is saved with ".ova" extension, as one would expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/download needs-investigation A bug not 100% confirmed/fixed
Projects
None yet
Development

No branches or pull requests

5 participants