Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset browser settings should reset shields/social media/extensions settings #4421

Open
srirambv opened this issue May 13, 2019 · 1 comment
Open

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented May 13, 2019

Description

Reset browser settings should reset shields/social media/extensions settings

Steps to Reproduce

  1. Change default shields settings
  2. Disable social media buttons
  3. Reset browser settings, doesn't reset shields/social media

Actual result:

Reset browser settings doesnt reset shields/social media/extensions settings

Expected result:

Reset browser settings should reset shields/social media/extensions settings

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

All

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the dev channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Does the issue resolve itself when disabling Brave Rewards?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Miscellaneous Information:

cc: @tomlowenthal @bbondy @diracdeltas @bsclifton

@bsclifton
Copy link
Member

@bsclifton bsclifton commented May 16, 2019

@mkarolin as you did the most recent version of reset settings, could you check this out? 😄

@rebron rebron added the priority/P4 label May 24, 2019
@rebron rebron removed this from Untriaged backlog in Front End May 24, 2019
@rebron rebron added this to P4 backlog in Settings May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Settings
P4 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.