New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook for new tab page should be hosted on brave-core and not brave-ui #4445

Closed

cezaraugusto opened this issue May 14, 2019 · 1 comment

Labels

dev-concern feature/new-tab

Milestone

Closed / Dupe / I...

Contributor

cezaraugusto commented May 14, 2019

Reasons:

Speed-up migration process (one repo instead of two)
Un-tie feature-specific components from our shared component library

Ideally, all brave-core features should be hosted in brave-core but NTP is the best candidate as it's the least complex feature so far.

cezaraugusto added the feature/new-tab label

rebron added the dev-concern label

Contributor Author

cezaraugusto commented Jan 17, 2020

Closing at this task is completed

cezaraugusto closed this

bbondy added this to the Closed / Invalid milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.