Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook for new tab page should be hosted on brave-core and not brave-ui #4445

Closed
cezaraugusto opened this issue May 14, 2019 · 1 comment
Closed

Comments

@cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented May 14, 2019

Reasons:

  • Speed-up migration process (one repo instead of two)
  • Un-tie feature-specific components from our shared component library

Ideally, all brave-core features should be hosted in brave-core but NTP is the best candidate as it's the least complex feature so far.

@cezaraugusto
Copy link
Contributor Author

@cezaraugusto cezaraugusto commented Jan 17, 2020

Closing at this task is completed

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.