Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to load https://www.forbes.com/crypto-blockchain/ when accessing using EU IP #4462

Open
Eurno opened this issue May 16, 2019 · 6 comments
Open

Comments

@Eurno
Copy link

@Eurno Eurno commented May 16, 2019

Description

When visiting https://www.forbes.com/crypto-blockchain/ the browser just shows an empty page which has "cookies on Forbes" on the left hand side. I have checked in other browsers and it is a problem that is only applicable to Brave.

Steps to Reproduce

Go to https://www.forbes.com/crypto-blockchain/ in the Brave browser.

EDITED: Needs to be done via EU IP address.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)

Revision | 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS | Mac OS X
JavaScript | V8 7.4.288.26
Flash | 32.0.0.171 /Library/Internet Plug-Ins/PepperFlashPlayer/PepperFlashPlayer.plugin
User Agent | Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.131 Safari/537.36

Version/Channel Information:

Tried with dev tools open (so not caching) and still the same. Using most up to date brave as far as I am aware. Have metamask, Presearch and ENU Ironman installed.

Other Additional Information:

Tried without shields, still persists. Console lists the following error:

VM210:1 Uncaught SyntaxError: Unexpected token o in JSON at position 1
at JSON.parse ()
at consentIsSet (?toURL=https://www.forbes.com/crypto-blockchain:32)

With the following message:

MessageEvent {isTrusted: true, data: "{"PrivacyManagerAPI":{"action":"getConsent","timestamp":1557996390795,"self":"forbes.com"}}", origin: "https://www.forbes.com", lastEventId: "", source: Window, …}

@bsclifton bsclifton added this to To do in Web Compatibility via automation May 18, 2019
@bsclifton
Copy link
Member

@bsclifton bsclifton commented May 18, 2019

@Eurno for debugging, can you please try to temporarily disable metamask? (you should be able to via brave://extensions)

Metamask and other extensions sometimes modify the DOM, which can cause web compatibility problems. I'm not using any extensions and the link above works for me (shields up and down).

@srirambv
Copy link
Collaborator

@srirambv srirambv commented May 18, 2019

@bsclifton its a GDPR cookie issue. If you are behind EU VPN then you can reproduce the issue.
image

Redirect URL gets a 302 code when shields is down which is why its not loading the page
image

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented May 20, 2019

I tested from a UK IP address, saw the same issue. consent.trustarc.com seems to be the culprit, possibly have issues loading/using the cookie to show the GDPR.

@kjozwiak kjozwiak changed the title Fails to load https://www.forbes.com/crypto-blockchain/ Fails to load https://www.forbes.com/crypto-blockchain/ when accessing using EU IP May 27, 2019
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented May 27, 2019

Reproduced the same thing @srirambv mentioned above. Works fine when accessing via a NA IP address. However, when loading the website from EU, you'll run into the issue. Most likely something to do with the way GDPR cookies are being set. Looks like once you consent and set the cookies, the redirect doesn't occur.

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jun 10, 2019

I'm not sure if filters is the answer, but something like this has been used; Not the first time I've seen trustarc cause issues.

@@||consent-pref.trustarc.com^$subdocument,domain=forbes.com
@@||truste-svc.net/cookie_js/$subdocument,domain=forbes.com
@@||consent.trustarc.com^$image,domain=forbes.com
@@||consent.trustarc.com/asset/$script,domain=forbes.com
@@||consent.truste.com/notice$script,domain=forbes.com
@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Mar 8, 2020

I've rechecked this. @Eurno I'm getting the consent message, with shields on. Seems to be okay now we can get past the consent dialog. (Tested with Shields=ON)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.