Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pref to show 24 hour time vs 12 hour am/pm on NTP #4470

Closed
thwaller opened this issue May 16, 2019 · 1 comment
Closed

Add pref to show 24 hour time vs 12 hour am/pm on NTP #4470

thwaller opened this issue May 16, 2019 · 1 comment

Comments

@thwaller
Copy link

@thwaller thwaller commented May 16, 2019

Have you searched for similar issues?

Yes, I have done a few searches. It appears that the ending statement on all is that Brave should be respecting the locale of the host computer. This is not the case for me.

Description

On the Brave homepage / startpage shows the current time in 12 hour am/pm format. I would like this to be 24 hour format, like the rest of my system.

Steps to Reproduce

View the Brave homepage / startpage.

Actual result:

Brave shows the time in 12 hour am/pm format vs the system setting of 24 hour.

Expected result:

Brave should be respecting the system locale, or have a setting to change it to the desired format.

Reproduces how often:

At all times.

Brave version (brave://version info)

Brave Version 0.65.92 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Ubuntu Release 18.04.2 LTS (Bionic Beaver) 64-bit
Kernel Linux 5.0.0-15-generic x86_64

Version/Channel Information:

Not tested

  • Can you reproduce this issue with the current release? -- Not tested
  • Can you reproduce this issue with the beta channel? -- Not tested
  • Can you reproduce this issue with the dev channel? -- Not tested
  • Can you reproduce this issue with the nightly channel? -- Not tested

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

I have read a few posts on this. It appears that the "resolution" is that Brave respects the host system's locale. This is not the case.

@rebron rebron changed the title 24 hour time vs 12 hour am/pm Add pref to show 24 hour time vs 12 hour am/pm on NTP May 16, 2019
@rebron rebron added this to Untriaged backlog in New Tab page May 17, 2019
@bsclifton
Copy link
Member

@bsclifton bsclifton commented May 18, 2019

Thanks for the report 😄 We have this captured with #1308

I'm happy to report that both @imptrx and @cezaraugusto will be working on enhancements for the new tab page soon! Folks wanting to follow along can check out the project board here:
https://github.com/brave/brave-browser/projects/19

@bsclifton bsclifton closed this May 18, 2019
@bsclifton bsclifton added this to the Dupe / Invalid / Not actionable milestone May 18, 2019
@bsclifton bsclifton added the duplicate label May 18, 2019
@bsclifton bsclifton removed this from Untriaged backlog in New Tab page May 18, 2019
@rebron rebron added closed/duplicate and removed duplicate labels May 22, 2019
@bsclifton bsclifton added duplicate and removed duplicate labels May 26, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.