Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country specific Add Funds for BR #4476

Closed
mandar-brave opened this issue May 17, 2019 · 1 comment

Comments

@mandar-brave
Copy link
Collaborator

commented May 17, 2019

Need to remove other currencies from add-funds dialog.
This is specific to country - Japan. A user in country Japan should automatically get the image below when the user tries to add-funds. ROW remains the same,

See image in fix:
image

cc @NejcZdovc

@mandar-brave mandar-brave added this to Untriaged Backlog in Rewards via automation May 17, 2019

@NejcZdovc NejcZdovc added this to the 0.67.x - Nightly milestone May 17, 2019

@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards May 17, 2019

@NejcZdovc NejcZdovc added this to Jason in Rewards Team May 17, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 21, 2019

@jasonrsadler jasonrsadler added the QA/Yes label May 21, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 21, 2019

@NejcZdovc NejcZdovc moved this from P1 & P2 Backlog to In Progress in Rewards May 22, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 22, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 22, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 22, 2019

@jasonrsadler jasonrsadler moved this from In Progress to Review/QA in Rewards May 22, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 23, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 23, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 24, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 24, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 24, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 25, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 28, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 28, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 28, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 28, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 28, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 28, 2019

Rewards automation moved this from Review/QA to Done May 28, 2019

Rewards Team automation moved this from Jason to Closed May 28, 2019

@NejcZdovc NejcZdovc moved this from Done to Waiting uplift in Rewards May 28, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 28, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 28, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 28, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 29, 2019

jasonrsadler added a commit to brave/brave-core that referenced this issue May 29, 2019

@NejcZdovc NejcZdovc moved this from Waiting uplift to Done in Rewards May 30, 2019

@kjozwiak

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Verification PASSED on macOS 10.14.5 x64 VM using the following build:

Brave 0.66.89 Chromium: 75.0.3770.87 (Official Build) beta(64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Mac OS X
  • ensured BAT is the only token available when adding funds via Add Funds
  • ensured that the FAQ link at the bottom of the Add Funds modal is working as expected
  • ensured that the QR button is being displayed correctly when clicking on the Show QR Code
  • ensured that scanning the QR code displays the correct address
  • ensured that you can send funds to the address being displayed under Add Funds
  • ensured that you can still restore a previous wallet using the Restore feature
  • ensured that the correct BAT address/QR code is being displayed after restoring a wallet using the Restore feature
  • ensured that all the other tokens are being displayed under Add Funds when using the following languages/regions: Canada, Germany, France, Spain, Brazil, Hong Kong

Screen Shot 2019-06-13 at 11 24 37 AM

Verification passed on

Brave 0.66.89 Chromium: 75.0.3770.87 (Official Build) beta (64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Linux

image

Verification passed on

Brave 0.66.92 Chromium: 75.0.3770.90 (Official Build) beta (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Windows 10 OS Version 1809 (Build 17763.557)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.