-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add built-in Ethereum remote client / wallet / Dapp browser #4494
Comments
This is on Nightly, there will be follow up work but I'm closing! |
Added test plan above. |
@bbondy @tomlowenthal would running through https://github.com/brave/ethereum-remote-client/wiki/Testing be sufficient enough for QA verification? It's basically similar to what's outlined under #4494 (comment) but more detailed. |
sgtm |
Verification PASSED on
Account Creation
Import & Recovery
Settings page
Branding
BAT
DappsUse a dapp such as https://www.cryptokitties.co/ for testing
Transactions
Accounts/Hardware
Failed TransactionsSuccessful TransactionsTransaction appearing under UpholdConnected to Nano LedgerConnected to Trezor |
Most verification passed on
Account Creation
Import & Recovery
Settings page
Branding
BAT
DappsUse a dapp such as https://www.cryptokitties.co/ for testing
Transactions
Accounts/Hardware
Wallet creation successConnect to Daap siteSignin to Daap siteHardware Wallet DetectConnect new hardware and unlock walletTrezor Wallet connectedLedger wallet connectedConfirmed transactionTransaction notificationInsufficient funds message |
Most verification passed on
Account Creation
Import & Recovery
Settings page
Branding
BAT
DappsUse a dapp such as https://www.cryptokitties.co/ for testing
Transactions
Accounts/Hardware
Successful wallet creationLedger Nano connectedTrezor ConnectedSuccessful transactionTransaction notificationDapp connectDapp signInsufficient funds |
Can you please elaborate, why it needs to wait for it? |
We're in the process of adding a first class Ethereum remote client / wallet feature to Brave by integrating a fork of Metamask that we'll modify, enhance and maintain. Sometimes native APIs that only Brave supports will be used, in those cases it probably doesn't make sense to upstream those parts.
We'll be upstreaming as much as we can to MetaMask. We have been, and will continue to collaborate with the MetaMask team as this work progresses.
Some bigger main differences will be:
window.ethereum
andweb3
).Rollout:
Future Brave rewards features will integrate and use this wallet support for P2P transactions.
Some stats from MetaMask which are relevant :
Here's some stats for the month of April for MetaMask:
Source:
https://medium.com/metamask/metamask-metrics-fbec0e2ceaa7
Here are the issues closed as part of this feature:
https://github.com/brave/brave-browser/issues?q=label%3Afeature%2Fcrypto-wallets+is%3Aclosed
Test Plan
I'm going to need help with this but:
New profile and navigating to brave://wallet or chrome://wallet should take a bit longer the first time and actually install the component and work seamlessly.
New profile and instead going to the hamburger menu for crypto wallet should do the same and install and open the wallet.
Chromium Process Task Manager in the hamburger menu tools should not show that it is running before installing it via one of the 2 above methods.
Test basic wallet functionality for ETH send/receive
Test basic wallet functionality for ERC20 send/receive
Test basic Dapp functionality, buy a cryptokitty and Sire it. Use a Dex.
Try changing from mainnet to another network, make sure it works.
Check closed issues that are labeled feature/crypto-wallets inside of 0.70.x milestone for more ideas.
The text was updated successfully, but these errors were encountered: