Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize social media links in tipping banner #4538

Open
diracdeltas opened this issue May 22, 2019 · 3 comments
Open

sanitize social media links in tipping banner #4538

diracdeltas opened this issue May 22, 2019 · 3 comments
Assignees
@diracdeltas
Labels
priority/P4 sec-low

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 22, 2019

see brave/brave-ui#466 for details

test plan:

  1. go to nate.blue (site won't load)
  2. open tipping banner
  3. should see no social media links
@diracdeltas diracdeltas self-assigned this May 22, 2019
@diracdeltas diracdeltas mentioned this issue May 22, 2019
Closed
@diracdeltas
Copy link
Member Author

@diracdeltas diracdeltas commented May 22, 2019

marking as p4 since this is mostly for defense in depth (publishers addressed the issue in their database already)
@nate-red
Copy link

@nate-red nate-red commented May 22, 2019

I disclosed this on H1, and you are using my domain in your test plan.

If you need help for this, don't hesitate to poke me.
@diracdeltas
Copy link
Member Author

@diracdeltas diracdeltas commented May 22, 2019

hi @nate-fr thanks! we fixed this on the server side (may take a few days for caches to update) so your test PoC should no longer work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diracdeltas diracdeltas

Labels
priority/P4 sec-low
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@diracdeltas @nate-red
You can’t perform that action at this time.