Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pending contributions to mojo interface #4620

Closed
NejcZdovc opened this issue May 28, 2019 · 0 comments
Closed

Move pending contributions to mojo interface #4620

NejcZdovc opened this issue May 28, 2019 · 0 comments
Assignees
@NejcZdovc
Labels
QA/No feature/rewards release-notes/exclude
Milestone
0.67.x - Release

Comments

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented May 28, 2019

We need to move PendingContribution in vendor/bat-native-ledger/include/bat/ledger/publisher_info.h into mojo interface.

Example how to do this brave/brave-core#2432
@NejcZdovc NejcZdovc self-assigned this May 28, 2019
@NejcZdovc NejcZdovc added this to New Issues in Rewards via automation May 28, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue May 28, 2019
@NejcZdovc
Moves pending contributon into mojom definition
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
Loading status checks…
0b6f434 
Resolves brave/brave-browser#4620
@NejcZdovc NejcZdovc mentioned this issue May 28, 2019
Merged
8 of 28 tasks complete
@NejcZdovc NejcZdovc added the QA/No label May 28, 2019
@NejcZdovc NejcZdovc moved this from New Issues to Review/QA in Rewards May 28, 2019
@NejcZdovc NejcZdovc added this to the 0.67.x - Nightly milestone May 28, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue May 28, 2019
@NejcZdovc
Moves pending contributon into mojom definition
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
Loading status checks…
fb8d2a4 
Resolves brave/brave-browser#4620
NejcZdovc added a commit to brave/brave-core that referenced this issue May 28, 2019
@NejcZdovc
Moves pending contributon into mojom definition
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
Loading status checks…
f27c90c 
Resolves brave/brave-browser#4620
NejcZdovc added a commit to brave/brave-core that referenced this issue May 28, 2019
@NejcZdovc
Moves pending contributon into mojom definition
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
Loading status checks…
6981d04 
Resolves brave/brave-browser#4620
NejcZdovc added a commit to brave/brave-core that referenced this issue May 28, 2019
@NejcZdovc
Moves pending contributon into mojom definition
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
Loading status checks…
91cafab 
Resolves brave/brave-browser#4620
NejcZdovc added a commit to brave/brave-core that referenced this issue May 28, 2019
@NejcZdovc
Moves pending contributon into mojom definition
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
Loading status checks…
7a831d4 
Resolves brave/brave-browser#4620
NejcZdovc added a commit to brave/brave-core that referenced this issue May 28, 2019
@NejcZdovc
Moves pending contributon into mojom definition
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
Loading status checks…
574f947 
Resolves brave/brave-browser#4620
Rewards automation moved this from Review/QA to Done May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
QA/No feature/rewards release-notes/exclude
Projects
None yet
Milestone
  0.67.x - Release
Linked pull requests

Successfully merging a pull request may close this issue.

Moves pending contributon into mojom definition
2 participants
@kjozwiak @NejcZdovc
You can’t perform that action at this time.