Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout flow breaks on Merch Direct powered sites #4752

Open
pes10k opened this issue Jun 6, 2019 · 3 comments
Open

Checkout flow breaks on Merch Direct powered sites #4752

pes10k opened this issue Jun 6, 2019 · 3 comments

Comments

@pes10k
Copy link
Contributor

@pes10k pes10k commented Jun 6, 2019

The Merch Direct API created modal checkout dialog is busted, unusably, when shields are up.

Specifically, the "submit payment" button doesn't appear and the dialog is collapsed.

When shields are up:
Screen Shot 2019-06-06 at 1 38 08 PM

Without shields:
Screen Shot 2019-06-06 at 1 38 52 PM

To recreate:

  1. Go to https://www.thisischon.com/products/65682-chon-lp
  2. Click "Add to" button
  3. Select "United States" and "standard" shipping (shouldn't matter specific values)
  4. click "checkout"
  5. Observed the next page is goofed
@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jun 6, 2019

I'll need to debug it more; but blocking one of these url's will cause issues.

https://api.ipinfodb.com/
https://m.stripe.network/
@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jun 7, 2019

Seems to affect many sites. (from a quick google) it'll be a generic whitelist.

https://www.jmtstore.com/
https://www.tokenhiphop.com/store
ryanbr added a commit to brave/adblock-lists that referenced this issue Jun 7, 2019
@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jun 13, 2019

Okay, the easy fix here will be just allow all cookies rather than 3rd-party. which will fix this.

@rebron rebron added this to To do in Web Compatibility via automation Jun 21, 2019
@rebron rebron added the priority/P3 label Jun 21, 2019
@rebron rebron moved this from To do to P3 backlog in Web Compatibility Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Web Compatibility
  
P3 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.