Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd-party cookie blocking causing website faults #4770

Open
ryanbr opened this issue Jun 10, 2019 · 6 comments
Open

3rd-party cookie blocking causing website faults #4770

ryanbr opened this issue Jun 10, 2019 · 6 comments

Comments

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jun 10, 2019

Description

When debuging this https://twitter.com/johnnyryan/status/1137967756148649984 Noticed that the slideshow will only work if allcookies are allowed.

If enabling 3rd party cookie blocking, it'll prevent slideshare.net from working.

The options in firefox (nightly), has an option to block all 3rd-party cookies. the slideshow works fine here.

Steps to Reproduce

  1. Enable Sheilds, with 3rd party cookie blocking.
  2. Visit https://twitter.com/johnnyryan/status/1137967756148649984
  3. Slideshow should still work.
  4. Repeat same task if need be in Firefox nightly, with 3rd-party cookies blocking enabled.
  5. Works fine in Firefox

Actual result:

Slideshow navigation being blocked.

Expected result:

Slideshow navigation shouldn't be blocked

Reproduces how often:

Occurs in Brave Nightly, and Release.

Brave version (brave://version info)

Tested in Nightly; Version 0.68.26 Chromium: 75.0.3770.80 (Official Build) nightly (64-bit)
Release: Version 0.65.118 Chromium: 75.0.3770.80 (Official Build) (64-bit)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    Yes
  • Does the issue resolve itself when disabling Brave Rewards?
    Have not checked, probably not an issue.
  • Is the issue reproducible on the latest version of Chrome?
    Chrome is also affected (if you set 3rd-party cookies to be blocked)

Miscellaneous Information:

@ryanbr
Copy link
Collaborator Author

@ryanbr ryanbr commented Jun 10, 2019

Wasn't sure to submit issue with Chrome or here, or both. I just submitted here for the moment.

@ryanbr ryanbr changed the title Blocking 3rd party cookies acts differently between Firefox and Brave 3rd-party cookie blocking causing website faults Jun 25, 2019
@ryanbr
Copy link
Collaborator Author

@ryanbr ryanbr commented Jun 26, 2019

Related to the cookie issues: #4285

ryanbr added a commit to ryanbr/referrer-whitelist that referenced this issue Jun 28, 2019
pilgrim-brave added a commit to brave/referrer-whitelist that referenced this issue Jul 8, 2019
Fix for vimeo playback issues brave/brave-browser#4770
@ryanbr
Copy link
Collaborator Author

@ryanbr ryanbr commented Jul 13, 2019

Should be fixed now. closing report

@ryanbr ryanbr closed this Jul 13, 2019
Web Compatibility automation moved this from To do to Done Jul 13, 2019
@rebron rebron removed this from Done in Web Compatibility Aug 13, 2019
@AndrewMorsillo
Copy link

@AndrewMorsillo AndrewMorsillo commented Mar 30, 2020

This is not fixed. Sites still fail with 3rd party cookies blocked. Specifically https://app.tactiq.io/ works fine in other browsers but fails on Brave with 3rd party cookies blocked.

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 30, 2020

Thanks for raising, @AndrewMorsillo - I confirmed this is either a regression or is still a problem

The original steps of testing https://twitter.com/johnnyryan/status/1137967756148649984 and trying to navigate from the preview don't work on Brave but works on Chrome

@bsclifton bsclifton reopened this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.