Get geolocations to work with our endpoint #48

bbondy · 2018-01-03T15:23:44Z

See in muon:
git grep google_api_endpoint
git grep google_api_key

See brave/brave:
git grep antimuon_google_api_endpoint
git grep antimuon_google_api_key


        Merge pull request #48 from brave/issue-81

Ensure ContentSettingsStore::RegisterExtension is called for components

bbondy · 2018-08-18T14:09:17Z

QA notes: just make sure geolocations works.

srirambv · 2018-09-21T02:18:11Z

Verification Passed on

Brave	0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Linux

Verified geolocation shown on https://browserleaks.com/geo
Verified geolocation shown on https://html5demos.com/geo/
Verified geolocation shown on https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation
Verified geolocation shown on https://maps.google.com/ when your location button is clicked

Verification PASSED on:

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Windows

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Mac OS X

Verified geolocation shown on https://browserleaks.com/geo
Verified geolocation shown on https://html5demos.com/geo/
Verified geolocation shown on https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation
Verified geolocation shown on https://maps.google.com/ when your location button is clicked

bbondy added this to the Milestone 2: To offer Installable and updatable builds milestone Jan 3, 2018

bbondy mentioned this issue Jan 12, 2018

Add Brave geolocations and system network redirect #19

Merged

bbondy modified the milestones: Milestone 2: To offer Installable and updatable builds, Milestone 1: To be able to open source the repo Jan 12, 2018

bbondy closed this Jan 23, 2018

bbondy modified the milestones: Milestone 1: To be able to open source the repo, Releasable builds Jun 13, 2018

bbondy added QA/No QA/Yes labels Aug 18, 2018

srirambv removed the QA/No label Aug 20, 2018

srirambv mentioned this issue Aug 20, 2018

Geolocation doesn't show user location #783

Closed

srirambv added the QA Pass-Linux label Sep 21, 2018

GeetaSarvadnya added the QA Pass-Win64 label Sep 23, 2018

kjozwiak added QA Pass-macOS and removed QA/Yes labels Sep 25, 2018

bbondy added the QA/Yes label Sep 27, 2018

brave / brave-browser