Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`SEND TIPS` is not translated in Brave Panel for some locales #4868

Open
btlechowski opened this issue Jun 12, 2019 · 2 comments
Open

`SEND TIPS` is not translated in Brave Panel for some locales #4868

btlechowski opened this issue Jun 12, 2019 · 2 comments

Comments

@btlechowski
Copy link
Collaborator

@btlechowski btlechowski commented Jun 12, 2019

Steps to Reproduce

  1. Change language to Norwegian
  2. Open a verified creator page
  3. Open Brave Panel

Not reproducible in: Polish

Actual result:

SEND TIPS is not translated in Brave Panel

image

Expected result:

SEND TIPS is translated in Brave Panel

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.66.88 Chromium: 75.0.3770.87 (Offizieller Build) beta (64-Bit)
Überarbeitung 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
Betriebssystem Windows 7 Service Pack 1 (Build 7601.24465)
Brave 0.68.36 Chromium: 75.0.3770.87 (Offisiell delversjon)nightly (64-bit)
Versjon 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Windows 7 Service Pack 1 (Build 7601.24465)

cc @brave/legacy_qa @bsclifton @NejcZdovc

@rebron rebron added this to Untriaged Backlog in General Jun 13, 2019
@rebron rebron moved this from Untriaged Backlog to P1 & P2 Backlog in General Jun 18, 2019
@NejcZdovc NejcZdovc added this to New Issues in Rewards Jun 19, 2019
@rebron rebron added the priority/P2 label Jun 21, 2019
@NejcZdovc NejcZdovc moved this from New Issues to Backlog in Rewards Jul 2, 2019
@NejcZdovc NejcZdovc removed this from Backlog in Rewards Nov 15, 2019
@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Dec 10, 2019

Still occurs with 1.1.20 using Norwegian:

Brave 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)
Revision 99b6d241cf84f7fa7434ae8a59f9e74eb1464280-refs/branch-heads/3945@{#888}
OS macOS Versjon 10.13.6 (bygg 17G5019)

Screen Shot 2019-12-10 at 5 40 42 pm

@rebron rebron moved this from P1 & P2 Backlog to In progress in General Jan 14, 2020
@btlechowski
Copy link
Collaborator Author

@btlechowski btlechowski commented Feb 27, 2020

This is still reproducible in 1.4.x. However in google translate Send tip translates to Send tips.
image

I don't know if this is proper way to translate it though.

Brave 1.4.95 Chromium: 80.0.3987.122 (Official Build) (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

Not reproducible in Polish and German.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
General
  
In progress
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.