Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to test using `google_chrome_strings.grd` instead of `chromium_strings.grd` #487

Open
simonhong opened this issue Jul 5, 2018 · 0 comments
Open

Try to test using `google_chrome_strings.grd` instead of `chromium_strings.grd` #487

simonhong opened this issue Jul 5, 2018 · 0 comments

Comments

@simonhong
Copy link
Collaborator

@simonhong simonhong commented Jul 5, 2018

We have to manually fill some strings because they are empty in chromium_strings.grd.
This makes difficult to use script.
Instead, google_chrome_strings.grd has all strings. Worth to try it.
@bbondy bbondy added this to the Backlog milestone Jul 6, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@bbondy @rebron @simonhong
You can’t perform that action at this time.