Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use brave-extension by default #5

Closed
bbondy opened this issue Nov 10, 2017 · 1 comment
Closed

Use brave-extension by default #5

bbondy opened this issue Nov 10, 2017 · 1 comment

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Nov 10, 2017

No description provided.

@bbondy bbondy self-assigned this Nov 10, 2017
@bbondy bbondy removed their assignment Dec 5, 2017
@bbondy bbondy added this to the Milestone 1: Open Source milestone Dec 5, 2017
bbondy referenced this issue in brave/brave-core Jan 1, 2018
…sources

Fix brave/unofficial-snap#5
@bbondy bbondy self-assigned this Jan 1, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
Use frame_tree_node_id to get web-contents in case of no process ID
@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Releasable builds Jun 13, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 20, 2018

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.