Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode for new tabs page settings #5014

Closed
imptrx opened this issue Jun 21, 2019 · 5 comments · Fixed by brave/brave-core#3115
Closed

Dark mode for new tabs page settings #5014

imptrx opened this issue Jun 21, 2019 · 5 comments · Fixed by brave/brave-core#3115

Comments

@imptrx
Copy link

@imptrx imptrx commented Jun 21, 2019

Description

New tabs page's settings menu should adjust itself based on the user's currently set theme, whether it be Light, Dark or the theme set on the OS level.
Currently, the settings menu will look the same no matter what.

Design

The Dashboard Settings menu should support dark theme set at the OS level:
r0 background images dark theme

@imptrx imptrx self-assigned this Jun 21, 2019
@imptrx imptrx added this to Untriaged backlog in New Tab page Jun 21, 2019
@rebron rebron added the priority/P3 label Jun 27, 2019
@rebron rebron moved this from Untriaged backlog to P3 backlog in New Tab page Jun 27, 2019
@imptrx imptrx moved this from P3 backlog to In progress in New Tab page Jul 22, 2019
imptrx added a commit to brave/brave-core that referenced this issue Aug 7, 2019
@imptrx imptrx mentioned this issue Aug 7, 2019
9 of 32 tasks complete
imptrx added a commit to brave/brave-core that referenced this issue Aug 8, 2019
imptrx added a commit to brave/brave-core that referenced this issue Aug 12, 2019
@imptrx imptrx added this to the 0.70.x - Nightly milestone Aug 12, 2019
imptrx added a commit to brave/brave-core that referenced this issue Aug 13, 2019
@rebron rebron moved this from In progress to Completed in New Tab page Aug 14, 2019
@GeetaSarvadnya

This comment has been minimized.

Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Sep 19, 2019

Verification passed on

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)
@btlechowski

This comment has been minimized.

Copy link
Collaborator

@btlechowski btlechowski commented Sep 20, 2019

This issue is still reproducible on 0.69.128

image

It is not reproducible on 0.70.99
image

Tested Windows and Linux.

@kjozwiak I suggest we move the milestone to 0.70.x

@kjozwiak

This comment has been minimized.

Copy link
Member

@kjozwiak kjozwiak commented Sep 20, 2019

Seeing the same thing as @btlechowski as per #5014 (comment). @rebron @bsclifton do know if this landed in 0.69.x? As @btlechowski mentioned, the fix seems to be working under 0.70.99 CR: 77.0.3865.90 but not under 0.69.128 CR: 77.0.3865.75. Example:

Using 0.69.128 CR: 77.0.3865.75:

NTPtheme

Using 0.70.99 CR: 77.0.3865.90:

NTPthemeWorking

@cezaraugusto

This comment has been minimized.

Copy link
Member

@cezaraugusto cezaraugusto commented Sep 24, 2019

changing milestones as this work landed only in 0.70.x cc @kjozwiak

@LaurenWags

This comment has been minimized.

Copy link
Collaborator

@LaurenWags LaurenWags commented Oct 8, 2019

Verified passed with

Brave 0.70.110 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-10-08 at 3 35 18 PM

Screen Shot 2019-10-08 at 3 35 33 PM

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Dark mode
image

Light mode
image

Verification passed on

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Dark mode:

image

Light mode:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.