Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInvestigate whether to enable _google_chrome in grit_defines to minimize patches #502
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So far we have seen two kinds of use cases related to _google_chrome, and our solutions usually involve patching html/js files which should be minimized as much as possible.
Use _google_chrome if guard to hide chrome specific UI elements for branding, ex: brave/brave-core#212
Enable UI elements or code blocks which are only available for _google_chrome build, ex: brave/brave-core#220
We should go through all _google_chrome cases in the code base and evaluate whether enabling _google_chrome flag and selectively disabling it only when needed might give us a result of less patches, and revise our implementations accordingly if so.
cc @bridiver