Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser crash when changing shields settings #51

Closed
srirambv opened this issue Jan 15, 2018 · 3 comments
Closed

Browser crash when changing shields settings #51

srirambv opened this issue Jan 15, 2018 · 3 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 15, 2018

Browser crash when changing shields settings

  1. Visit http://cartoonhd.zone (used this because it detects adblockers)
  2. Enable FP and Block Phishing from shields
  3. Watch some video
  4. Open shields, FP and Block phishing was disabled, tried enabling again and browser crashed

Note: You might have to watch couple of videos for the adblocker to be detected on the site and show up anti-adblocker message

@bbondy
Copy link
Member

@bbondy bbondy commented Jun 6, 2018

@srirambv fixed?

@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Jun 6, 2018

Yes looks fixed. No crash on shields settings toggle.

@srirambv srirambv closed this Jun 6, 2018
@bbondy bbondy added this to the Releasable builds milestone Jun 14, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Aug 28, 2018

Validated the issue on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows
JavaScript V8 6.9.427.14
Flash 30.0.0.154

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification Pass with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/Yes labels Sep 25, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.