Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMinimize patches for {Chrome,Brave}Importer #511
Closed
Assignees
Labels
Comments
|
@bridiver has some more suggestions for minimizing these patches in comments on brave/brave-core@1581d1f |
|
Closing as @simonhong did some great cleanup on here recently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Follow-up for brave/brave-core#185.
@darkdh suggested some ideas for minimizing the patches currently required for the Chrome and Brave importers in his review comments for brave/brave-core#185. After a discussion we agreed the tradeoffs between changing the patch strategies deserved more careful consideration and it was more of a priority to ship BraveImporter and BraveProfileLock. This issue is meant as a reminder to reconsider and potentially implement some or all of those suggestions at a later date.