Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable chrome settings that send user data to google #512

Closed
jumde opened this issue Jul 10, 2018 · 7 comments · Fixed by brave/brave-core#244
Closed

Disable chrome settings that send user data to google #512

jumde opened this issue Jul 10, 2018 · 7 comments · Fixed by brave/brave-core#244

Comments

@jumde
Copy link
Contributor

@jumde jumde commented Jul 10, 2018

Disable:

  • use a web service to resolve navigation errors
  • prediction service to load pages quickly
  • use of web service to help resolve navigation errors
@yrliou

This comment has been minimized.

Copy link
Member

@yrliou yrliou commented Jul 11, 2018

Haven't dig deep into details, just a quick update for the prefs that could control these settings.

  • use a web service to resolve navigation errors: prefs.alternate_error_pages.enabled
  • prediction service to load pages quickly: prefs.net.network_prediction_options

@jumde Is there a typo in the third item? Do you mean "Use a web service to help resolve spelling errors"? If so, controlled by prefs.spellcheck.use_spelling_service, and is disabled by default.

@yrliou yrliou self-assigned this Jul 11, 2018
@yrliou

This comment has been minimized.

Copy link
Member

@yrliou yrliou commented Jul 11, 2018

@jumde The network prediction service for the second item seems only processing data locally mainly for prefetch, prerender, preresolve, and preconnect, I didn't see it sends data out to google in the chrome/browser/net/predictor.[cc|h], maybe we don't need to explicitly disable that pref and could keep this feature usable?
Feel free to correct me if I missed anything.

I also checked https://support.google.com/chrome/answer/114836?visit_id=1-636668839787347351-4200605008&p=settings_privacy&rd=1 and https://www.google.com/chrome/privacy/index.html, seems all local to me too, please let me know if there are other docs suggest it does.

@yrliou

This comment has been minimized.

Copy link
Member

@yrliou yrliou commented Jul 11, 2018

@jumde Should we make sure these two are also disabled?

  • Use a prediction service to help complete searches and URLs typed in the address bar
  • Automatically send some system information and page content to Brave to help detect dangerous apps and sites
@jumde

This comment has been minimized.

Copy link
Contributor Author

@jumde jumde commented Jul 11, 2018

@yrliou -

Re: the network prediction service, I looked at the code and I think the data is only sent if the LearnFromNavigation observers are set. We can keep this setting enabled if the processing is happening locally. Thanks for checking.

Re: Search Suggestions, we should disable them by default since user history will be sent to the default search engine.

Re: web service to help resolve navigation errors: navigate to - chrome://settings/?search=navigation%20errors

screen shot 2018-07-11 at 12 44 55 am

Re: Dangerous Apps/Sites - kSafeBrowsingExtendedReportingOptInAllowed only works if Safe Browsing is enabled which as of now is not, but it would be great to disable this reporting by default.

@srirambv

This comment has been minimized.

Copy link
Collaborator

@srirambv srirambv commented Sep 25, 2018

@jumde @yrliou any QA test plan for this?

@jumde

This comment has been minimized.

Copy link
Contributor Author

@jumde jumde commented Sep 25, 2018

@srirambv - The test plan is specified here: brave/brave-core#244

@srirambv

This comment has been minimized.

Copy link
Collaborator

@srirambv srirambv commented Sep 25, 2018

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification passes on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
@bbondy bbondy moved this from Dev channel blockers to Completed in Security & Privacy Oct 30, 2018
@rebron rebron removed this from Completed in Security & Privacy Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.