Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ContributionInfo to mojo interface #5130

Closed
NejcZdovc opened this issue Jul 4, 2019 · 0 comments
Closed

Move ContributionInfo to mojo interface #5130

NejcZdovc opened this issue Jul 4, 2019 · 0 comments
Labels
QA/No dev-concern feature/rewards priority/P5 release-notes/exclude
Milestone
0.69.x - Release

Comments

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Jul 4, 2019

We need to move ContributionInfo in vendor/bat-native-ledger/include/bat/ledger/publisher_info.h into mojo interface.

Example how to do this brave/brave-core#2432
@NejcZdovc NejcZdovc added this to Icebox in Rewards Jul 4, 2019
@jdkuki jdkuki self-assigned this Jul 5, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 8, 2019
@jdkuki
Remove export and expose mojo type
Loading status checks…
df9d20c 
Resolves brave/brave-browser#5130
Minor addition to #2432
@jdkuki jdkuki mentioned this issue Jul 8, 2019
Merged
7 of 32 tasks complete
@NejcZdovc NejcZdovc moved this from Icebox to Review/QA in Rewards Jul 9, 2019
Rewards automation moved this from Review/QA to Done Jul 9, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA/No dev-concern feature/rewards priority/P5 release-notes/exclude
Projects
None yet
Milestone
  0.69.x - Release
Linked pull requests

Successfully merging a pull request may close this issue.

Remove export and expose mojo type
3 participants
@bsclifton @jdkuki @NejcZdovc
You can’t perform that action at this time.