Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFind a way to expose locale files to Storybook #5179
Labels
Comments
|
Perhaps have a webpack plugin which converts grd to json |
|
@petemill I think that we will need to first parse .grd then find associated _source.cc so that we will get correct keys for associated translation |
|
@NejcZdovc that's a good point, unless we start to use the c++ IDs in JS and remove the go-between layer, e.g. |
tmancey
pushed a commit
that referenced
this issue
Apr 9, 2020
…option_fix_1.7.x Fixed 3rd party cookies blocking behavior (uplift to 1.7.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After brave/brave-core#2857 we have two locales for the same features, one for brave-core (real one that goes to Transifex) and another one for storybook prototyping (named fakeLocale).
Ideally we could have both places using the same source. As far as I know Storybook can only read JavaScript, so maybe outputting results in
.grdfiles as JSON? I don't think it's possible without much work but having a single JSON file similar to extension's messages would be ideal.cc @petemill @mkarolin I don't think this is top priority but would be cool to have your input about what we can do right now with as low effort/time as possible.