Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fingerprint Protection and Block Phishing shields settings are not saved on a domain #52

Closed
srirambv opened this issue Jan 15, 2018 · 3 comments
Closed

Fingerprint Protection and Block Phishing shields settings are not saved on a domain #52

srirambv opened this issue Jan 15, 2018 · 3 comments
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes bug feature/shields
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 15, 2018

Fingerprint Protection and Block Phishing shields settings are not saved on a domain

STR

  1. Open any page
  2. Enable Fingeprint Protection and Block Phishing switch. page doesn't reload with the settings being saved for that page
@srirambv srirambv mentioned this issue Mar 14, 2018
Closed
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #52 from brave/welcome-fixes
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
644233d 
Welcome page fixes
@bbondy
Copy link
Member

@bbondy bbondy commented Jun 6, 2018

I think this is probably working now, could you verify @srirambv ?
@bbondy bbondy added this to To triage in 0.55.x - Release Jun 6, 2018
@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Jun 6, 2018

Yes this is fixed for FP.
@srirambv srirambv closed this Jun 6, 2018
@bbondy bbondy removed this from To triage in 0.55.x - Release Jun 6, 2018
@bbondy bbondy added this to the Milestone 3: June-July milestone Jun 6, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Aug 28, 2018 •
edited by kjozwiak

Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
@kjozwiak kjozwiak added QA Pass-macOS and removed QA/Yes labels Sep 26, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes bug feature/shields
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@bbondy @kjozwiak @srirambv @GeetaSarvadnya
You can’t perform that action at this time.