Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support priority for Brave Ads #5232

Open
jsecretan opened this issue Jul 12, 2019 · 2 comments
Open

Support priority for Brave Ads #5232

jsecretan opened this issue Jul 12, 2019 · 2 comments

Comments

@jsecretan
Copy link
Collaborator

@jsecretan jsecretan commented Jul 12, 2019

Description

Certain campaigns may need to be prioritized over others for a number of reasons. If certain campaigns have commitments attached to them and are underdelivering, they may need to serve over others available. This is common practice in ad trafficking.

This is dependent on the completion of #5231. On the campaign level, there is a "priority" field with a numerical value from 1-10, 1 meaning the highest priority. For the list of available ads to serve, the native ad library should sort eligible ads ascending by this value, and select by the highest priority first.

The round robin algorithm (#5945) would also change to work first within higher priority levels before going to lower priority levels.

@jsecretan jsecretan added this to New Issues in Rewards via automation Jul 12, 2019
@tmancey tmancey moved this from New Issues to In Progress in Rewards Jul 17, 2019
@tmancey tmancey moved this from In Progress to Backlog in Rewards Jul 17, 2019
@tmancey tmancey self-assigned this Jul 17, 2019
@tmancey tmancey moved this from Backlog to Icebox in Rewards Jul 17, 2019
@tmancey tmancey moved this from Icebox to Backlog in Rewards Jul 17, 2019
@tmancey tmancey added this to Terry in Rewards Team Jul 17, 2019
@tmancey tmancey removed their assignment Aug 22, 2019
@tmancey tmancey moved this from Backlog to In Progress in Rewards Nov 29, 2019
@tmancey tmancey assigned tmancey and jsecretan and unassigned tmancey Nov 29, 2019
@tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 6, 2019

@jsecretan Assigning to see if this issue is still relevant, thanks

@tmancey tmancey moved this from In Progress to Backlog in Rewards Dec 6, 2019
@tmancey tmancey added the QA/Yes label Jan 20, 2020
@tmancey tmancey changed the title Support priority for ads Support priority for Brave Ads Jan 20, 2020
@tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 22, 2020

Blocked while deciding if this issue is still relevant

@NejcZdovc NejcZdovc added this to New issues in Ads via automation Feb 10, 2020
@NejcZdovc NejcZdovc removed this from Backlog in Rewards Feb 10, 2020
@NejcZdovc NejcZdovc moved this from New issues to Backlog in Ads Feb 10, 2020
@tmancey tmancey moved this from Backlog to Icebox in Ads Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ads
  
Icebox
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.