Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up build config for web-ui #524

Open
bbondy opened this issue Jul 11, 2018 · 0 comments
Open

Clean up build config for web-ui #524

bbondy opened this issue Jul 11, 2018 · 0 comments

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Jul 11, 2018

Some things are still not specified:
https://github.com/brave/brave-core/blob/master/components/resources/BUILD.gn#L23

Instead make a resources/common build target that includes the things every web-ui uses.

Example of something missing:
common/locale

@bbondy bbondy added this to the Releasable builds milestone Jul 11, 2018
@bbondy bbondy self-assigned this Jul 11, 2018
@bbondy bbondy modified the milestones: Releasable builds, Backlog Jul 30, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@bbondy bbondy removed their assignment Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bbondy @rebron
You can’t perform that action at this time.