Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields panel doens't shrink to fit when advance options is hidden #53

Closed
srirambv opened this issue Jan 15, 2018 · 2 comments
Closed

Shields panel doens't shrink to fit when advance options is hidden #53

srirambv opened this issue Jan 15, 2018 · 2 comments
Assignees
@cezaraugusto
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes bug feature/shields
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 15, 2018

shields-advcontrol
@cezaraugusto cezaraugusto self-assigned this Jan 17, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #53 from brave/fix/88
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
18e3ab3 
fix native messaging dir for extensions that expect Google/Chrome (1p…
@bbondy bbondy added this to Cezar Augusto in 0.55.x - Release Jun 6, 2018
@bbondy bbondy added this to the Milestone 3: June-July milestone Jun 6, 2018
@bbondy
Copy link
Member

@bbondy bbondy commented Jun 6, 2018

If spending more than a day on this, I'd just remove the advanced collapsable feature.
@cezaraugusto cezaraugusto mentioned this issue Jun 12, 2018
Merged
@cezaraugusto cezaraugusto mentioned this issue Jul 2, 2018
Merged
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 2, 2018
@cezaraugusto
fix shields nor shrinking when advanced opt is hidden
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
Loading status checks…
dba1d6a 
fix brave/brave-browser#53
@cezaraugusto cezaraugusto removed this from Cezar Augusto in 0.55.x - Release Jul 4, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Aug 28, 2018 •
edited by LaurenWags

Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows
JavaScript V8 6.9.427.14
Flash 30.0.0.154

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
@LaurenWags LaurenWags added QA Pass-macOS and removed QA/Yes labels Sep 26, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes bug feature/shields
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

fix shields nor shrinking when advanced opt is hidden
5 participants
@bbondy @cezaraugusto @srirambv @LaurenWags @GeetaSarvadnya
You can’t perform that action at this time.