Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.google.com cookie mismatch after import #5313

Closed
bsclifton opened this issue Jul 22, 2019 · 6 comments · Fixed by brave/brave-core#3804
Closed

.google.com cookie mismatch after import #5313

bsclifton opened this issue Jul 22, 2019 · 6 comments · Fixed by brave/brave-core#3804

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Jul 22, 2019

Description

Import cookies from Chrome/Firefox will cause cookie mismatch error on google.com

Test plan / Steps to Reproduce

  1. Clean cookies on Chrome/Firefox and login in google account
  2. Import cookies from Chrome/Firefox to Brave
  3. Login google account on Brave

Actual result:

image

Expected result:

No cookie mismatch error

Reproduces how often: [What percentage of the time does it reproduce?]

100%

@bsclifton

This comment has been minimized.

Copy link
Member Author

@bsclifton bsclifton commented Jul 22, 2019

recently reported by @johnnyryan

I install, and use the settings screen to copy over bookmarks, passwords, and everthing else I can from Safari, Chrome, and Firefox. Then I load up Gmail, and get a "cookie mismatch" error that makes it impossible to use Gmail. The only way to solve it is to delete all cookies from all time

Here's the fix we did in Muon:
https://github.com/brave/browser-laptop/pull/11647/files

@bsclifton bsclifton self-assigned this Jul 22, 2019
@rebron rebron moved this from To do to P1 & P2 backlog in Web Compatibility Jul 23, 2019
@rebron rebron added 1.0 and removed 1.0-suggestion labels Oct 22, 2019
@bsclifton

This comment has been minimized.

Copy link
Member Author

@bsclifton bsclifton commented Oct 30, 2019

Needs to be retested after brave/brave-core#3804 was merged... will try this out soon

@simonhong

This comment has been minimized.

Copy link
Collaborator

@simonhong simonhong commented Oct 30, 2019

I tested with the fix(brave/brave-core#3804).
After importing chrome's cookie, I loaded google.com and brave is logged in state w/o any error.

@bsclifton

This comment has been minimized.

Copy link
Member Author

@bsclifton bsclifton commented Oct 31, 2019

This is great news! Let's close this issue for now- we can always re-open if we get reports

@bsclifton bsclifton closed this Oct 31, 2019
Web Compatibility automation moved this from P1 & P2 backlog to Done Oct 31, 2019
@simonhong simonhong mentioned this issue Oct 31, 2019
11 of 32 tasks complete
@simonhong simonhong added this to the 0.71.x - Beta milestone Oct 31, 2019
@LaurenWags

This comment has been minimized.

Copy link
Collaborator

@LaurenWags LaurenWags commented Oct 31, 2019

QA/Blocked until we get a new build. Will be available in 0.71.107 and above. Label mistakenly added. This should be available in 0.71.106 and above.

@LaurenWags LaurenWags added QA/Blocked and removed QA/Blocked labels Oct 31, 2019
@LaurenWags

This comment has been minimized.

Copy link
Collaborator

@LaurenWags LaurenWags commented Oct 31, 2019

Verified passed with

Brave 0.71.106 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description
  • Verified test plan from brave/brave-core#3804
  • Verified I could import cookies for a single Google account and navigate to gmail, etc without error
  • Verified I could import cookies for two Google accounts and navigate to gmail, etc with error
  • Verified after importing cookies for two Google accounts I could add a third and navigate to gmail, etc without error

Verification passed on

Brave 0.71.106 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS
  • Verified STR from description
  • Verified test plan from brave/brave-core#3804
  • Verified I could import cookies for a single Google account and navigate to gmail, etc without error
  • Verified I could import cookies for two Google accounts and navigate to gmail, etc with error

Verification passed on

Brave 0.71.107 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from description
  • Verified test plan from brave/brave-core#3804
  • Verified I could import cookies for a single Google account and navigate to gmail, etc without error
  • Verified I could import cookies for two Google accounts and navigate to gmail, etc with error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.