Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for unexpected non-user-initiated network activity #537

Closed
tomlowenthal opened this issue Jul 13, 2018 · 1 comment
Closed

Test for unexpected non-user-initiated network activity #537

tomlowenthal opened this issue Jul 13, 2018 · 1 comment
Labels
closed/invalid duplicate

Comments

@tomlowenthal
Copy link
Contributor

@tomlowenthal tomlowenthal commented Jul 13, 2018

We should ensure that any network request Brave makes without user interaction is deliberate. With a whitelist of expected network requests, we can test Brave build candidates to ensure that they don't make other network requests.

Replaces brave/browser-laptop#12690
@tomlowenthal tomlowenthal mentioned this issue Jul 13, 2018
Closed
@bbondy bbondy added this to the Backlog milestone Jul 26, 2018
@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Oct 23, 2018

i think this was done with #1682 and AFAIK the audit command is running in the build pipeline now
@bbondy bbondy modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Oct 24, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid duplicate
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@diracdeltas @tomlowenthal @bbondy @kjozwiak
You can’t perform that action at this time.