Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Scripts by Origin (first party / third party) #538

Open
tomlowenthal opened this issue Jul 13, 2018 · 5 comments
Open

Block Scripts by Origin (first party / third party) #538

tomlowenthal opened this issue Jul 13, 2018 · 5 comments

Comments

@tomlowenthal
Copy link
Member

@tomlowenthal tomlowenthal commented Jul 13, 2018

We should provide a Shields UX which makes it easy to select which scripts to enable or block. In particular, we should allow users to decide whether they want to block all scripts on a page, or only scripts from third parties.

Replaces brave/browser-laptop#11617

@bbondy
Copy link
Member

@bbondy bbondy commented Jul 26, 2018

I think we already have this, implemented by @yrliou. I think we need to tweak the UX eventually but probably not before the main September milestone.

@bbondy bbondy added this to the Backlog milestone Jul 26, 2018
@tomlowenthal
Copy link
Member Author

@tomlowenthal tomlowenthal commented Jul 30, 2018

I don't see it in the test builds. Is it located somewhere non-obvious?

@bbondy
Copy link
Member

@bbondy bbondy commented Jul 31, 2018

maybe not so obvious but you can scroll on the shields panel down

@bsclifton bsclifton modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Oct 30, 2018
@bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 30, 2018

Closing as this is implemented 😄

@bsclifton bsclifton closed this Oct 30, 2018
@tomlowenthal
Copy link
Member Author

@tomlowenthal tomlowenthal commented Nov 2, 2018

I think that what's implemented right now (in both old-style and new-style panels) is the ability to block scripts and re-enable specific scripts. I don't see the ability to pick block all scripts|block 3rd party scripts|don't block scripts. Maybe I'm just totally missing it, but I'm going to re-open this until I actually see this. Can y'all confirm @yrliou @cezaraugusto?

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Shields
  
Back-end
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.