Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser shows error icon for browser peek preview on Windows #54

Closed
srirambv opened this issue Jan 15, 2018 · 3 comments
Closed

Browser shows error icon for browser peek preview on Windows #54

srirambv opened this issue Jan 15, 2018 · 3 comments
Labels
OS/Windows QA Pass-Win64 QA/Yes bug
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 15, 2018

image
@srirambv srirambv added the bug label Jan 15, 2018
@srirambv srirambv mentioned this issue Feb 16, 2018
Closed
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #54 from brave/fix/83
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ae0f9c8 
use cc_wrapper env var if present
@bbondy
Copy link
Member

@bbondy bbondy commented Jun 6, 2018

cc @yrliou
@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Jun 6, 2018

Looks fixed
@srirambv srirambv closed this Jun 6, 2018
@bbondy bbondy added this to the Releasable builds milestone Jun 14, 2018
@emerick emerick mentioned this issue Aug 3, 2018
Closed
@jonathansampson jonathansampson mentioned this issue Aug 5, 2018
Closed
@srirambv srirambv mentioned this issue Aug 8, 2018
Closed
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Aug 28, 2018 •
edited by btlechowski

Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows
JavaScript V8 6.9.427.14
Flash 30.0.0.154
Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7
@srirambv srirambv added the OS/Windows label Sep 21, 2018
@btlechowski btlechowski removed the QA/Yes label Sep 21, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
@Brave-Matt Brave-Matt mentioned this issue Dec 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Windows QA Pass-Win64 QA/Yes bug
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@bbondy @srirambv @btlechowski @GeetaSarvadnya
You can’t perform that action at this time.