chrome.VisualElementsManifest.xml is not renamed on Windows

[Iffabled]

Test plan

See brave/brave-core#4299

Description

Windows 10 allows you to create a <app_name>.VisualElementsManifest.xml file for your <app_name>.exe, that configures app's look in the Start Menu. Chrome comes with it by default, and it is bundled with Brave, but it is not renamed to brave.VisualElementsManifest.xml, so the OS doesn't detect it.

Steps to Reproduce

1. Open the Start Menu.
2. Pin Brave to Start.
3. Look at Brave's entry on the app list and at Brave's tile.

Actual result:

Brave's tile and app list entry are not customized.

Expected result:

Brave's tile and app list entry are customized.

Reproduces how often:

Always reproduces.

Brave version (brave://version info)

Brave | 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision | 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS | Windows 10 OS Version 1903 (Build 18362.239)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? No
• Does the issue resolve itself when disabling Brave Rewards? No
• Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

This file can be used to customize things like the tile's background color, icons used for the smaller and the medium tile, whether the tile has the app's name or what color is the app's name.

[rossjrw]

Noting that the actual result listed here is not what I experienced - on my end, the custom colour background shows up as the system colour, not as Brave's grey.

Not really sure why it's grey when the secondary colour everywhere else is purple.

[Iffabled]

Noting that the actual result listed here is not what I experienced - on my end, the custom colour background shows up as the system colour, not as Brave's grey.

I have set my system color to grey.

Not really sure why it's grey when the secondary colour everywhere else is purple.

I didn't modify the file's content to better suit Brave, I just renamed it so that it would be loaded by Windows.

[bsclifton]

I did an implementation of this but only after merging did I realize we aren't creating different versions per release channel

Implementation I did:
brave/brave-core#4299

Reverted with:
brave/brave-core#4358

[bsclifton]

When solving this issue properly (respecting channels), we can update the graphics used for the icons if we'd like:
https://github.com/brave/brave-core/tree/master/app/theme/brave/win/tiles

• Logo.png will be scaled (if needed) and displayed at 150px by 150px
• SmallLogo.png will be scaled (if needed) and displayed at 70px by 70px

We can also change the background color (default is gray) and we can turn on/configure text color

The proper thing to do would be to add the icons under https://github.com/brave/brave-core/tree/master/app/theme/brave/win and then copy the channel specific ones into the tiles directory at build time via GN

It's possible this is already supported by the installer; for more info see:
https://cs.chromium.org/chromium/src/chrome/BUILD.gn?l=1511-1516&rcl=d08e75a3f95509e23b3793fb8ad0027dc8f4a2f7

Here's what the icons look like after wiring up brave.VisualElementManifest.xml:
(actual tile circled in RED)

Medium tile

Small tile