Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to 'Add to Brave' instead of 'Add to Chrome' on Private/Tor/Guest follow up to #790 #5431

Open
srirambv opened this issue Jul 29, 2019 · 1 comment

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jul 29, 2019

Description

Change to 'Add to Brave' instead of 'Add to Chrome' on Private/Tor/Guest

Steps to Reproduce

  1. Open chrome store on Private/Tor/Guest window
  2. Shows Add to Chrome button even though disabled

Actual result:

image

Expected result:

Should show Add to Brave even if its disabled

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.70.3 Chromium: 76.0.3809.62 (Official Build) nightly (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@rebron rebron added this to Untriaged Backlog in General Jul 29, 2019
@rebron rebron removed this from Untriaged Backlog in General Jul 30, 2019
@rebron rebron added this to Untriaged backlog in Front End Jul 30, 2019
@bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 5, 2019

Should have been fixed with brave/brave-core#2845 - the extension should be loading in these window types also. Curious why this doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Front End
  
Untriaged backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.