Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave shields extension action toggles are broken #5470

Closed
bridiver opened this issue Jul 30, 2019 · 1 comment
Closed

brave shields extension action toggles are broken #5470

bridiver opened this issue Jul 30, 2019 · 1 comment

Comments

@bridiver
Copy link
Collaborator

@bridiver bridiver commented Jul 30, 2019

Description

None of the toggles for brave shields settings take effect

Steps to Reproduce

  1. Go to google.com
  2. Turn off brave shields for google.com

Actual result:

Nothing changes and the page doesn't reload

Expected result:

Settings should change and reload the page

Reproduces how often:

Always

Brave version (brave://version info)

0.70.16

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes
@bridiver bridiver added the regression label Jul 30, 2019
@bridiver bridiver self-assigned this Jul 30, 2019
@bridiver bridiver added this to the 0.70.x - Nightly milestone Jul 30, 2019
bridiver added a commit to brave/brave-core that referenced this issue Jul 30, 2019
change brave shields method names for clarity
fix brave/brave-browser#5470
@bridiver bridiver mentioned this issue Jul 30, 2019
12 of 32 tasks complete
@bridiver bridiver added the QA/Yes label Jul 30, 2019
bridiver added a commit to brave/brave-core that referenced this issue Jul 30, 2019
change brave shields method names for clarity
fix brave/brave-browser#5470
bridiver added a commit to brave/brave-core that referenced this issue Jul 30, 2019
change brave shields method names for clarity
fix brave/brave-browser#5470
bridiver added a commit to brave/brave-core that referenced this issue Jul 31, 2019
change brave shields method names for clarity
fix brave/brave-browser#5470
bridiver added a commit to brave/brave-core that referenced this issue Jul 31, 2019
change brave shields method names for clarity
fix brave/brave-browser#5470
bridiver added a commit to brave/brave-core that referenced this issue Aug 28, 2019
change brave shields method names for clarity
fix brave/brave-browser#5470
bridiver added a commit to brave/brave-core that referenced this issue Aug 29, 2019
change brave shields method names for clarity
fix brave/brave-browser#5470
@bsclifton bsclifton modified the milestones: 0.70.x - Dev, 0.69.x - Beta Aug 29, 2019
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 3, 2019

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux
  • Verified shields up/down causes the page to reload
  • Verified all individual switch on shields causes page to reload when toggled

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1809 (Build 17763.379)
  • Verified shields up/down causes the page to reload
  • Verified all individual switch on shields causes page to reload when toggled

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified shields up/down causes the page to reload
  • Verified all individual switch on shields causes page to reload when toggled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.