Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udemy videos do not play with Shields OFF #5497

Open
Brandon-T opened this issue Aug 1, 2019 · 5 comments
Open

Udemy videos do not play with Shields OFF #5497

Brandon-T opened this issue Aug 1, 2019 · 5 comments

Comments

@Brandon-T
Copy link

@Brandon-T Brandon-T commented Aug 1, 2019

Description

Steps to Reproduce

  1. Go to https://www.udemy.com/the-complete-javascript-course/learn/lecture/5869076#overview
  2. Hit play on the video
  3. Infinite Loop (video doesn't play and console gets spammed)
  4. Console shows:
     VIDEOJS: WARN: Problem encountered with the current HLS playlist. HLS request errored at URL: HTTPS://h.udemycdn-a.com/851712/13059092/2018-06-20_14-09-58-c0ee9005191996b8b7a78bca8a0d912a/hls/hls_480/aa00ace74f03aa29f7b4bd0558ea42ff3b427.ts Switching to another playlist.
    
  5. Chrome & Firefox doesn't have this issue and console doesn't log these warnings in both.
  6. Disable Shields (shields down, you're browsing this site without privacy protection...): It still happens.
  7. Enable ALL cookies in "Global Shield Defaults" and refresh the page.. The site will load.

To reproduce the issue multiple times, clear your cookies and try the steps above.

Actual result:

Screen Shot 2019-08-01 at 10 18 47 AM

Expected result:

It should load the page with "Shields Down" and not force the user to disable "Global Shields".

Reproduces how often:

Easily Reproduced.

Brave version (brave://version info)

Brave 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Mac OS X
JavaScript V8 7.5.288.30
Flash (Disabled)
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.142 Safari/537.36
Command Line /Applications/Brave Browser.app/Contents/MacOS/Brave Browser --enable-dom-distiller --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=NewExtensionUpdaterService,DesktopPWAWindowing --disable-features=LookalikeUrlNavigationSuggestionsUI,AutofillServerCommunication,AudioServiceOutOfProcess,DefaultEnableOopRasterization,UnifiedConsent,AutofillSaveCardSignInAfterLocalSave,NetworkService,TranslateUI --flag-switches-begin --flag-switches-end
Executable Path /Applications/Brave Browser.app/Contents/MacOS/Brave Browser
Profile Path /Users/*******/Library/Application Support/BraveSoftware/Brave-Browser/Default

Version/Channel Information:

Not sure what this means but happens on every version of Brave.

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Yes. Can reproduce on all of the above.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? - No.
  • Does the issue resolve itself when disabling Global Shields? - Yes.
  • Does the issue resolve itself when disabling Brave Rewards? - No.
  • Is the issue reproducible on the latest version of Chrome? - No.

Miscellaneous Information:

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Aug 2, 2019

CCing @ryanbr. Mind taking a look at this when you have some time? Thanks!

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Aug 2, 2019

Just Allow all cookies, that should fix it.

@Brandon-T
Copy link
Author

@Brandon-T Brandon-T commented Aug 6, 2019

@ryanbr

Shields off (video loads indefinitely, console spams):
Screen Shot 2019-08-05 at 7 59 57 PM

All Cookies allowed (video loads indefinitely, console spams):
Screen Shot 2019-08-05 at 8 03 13 PM

Shields are off.. even if I choose Allow All Cookies from the drop down menu, it does not work..

It only works when chosen from the global shields! :(

If we have to turn it off globally to get it to work, then the menu option is broken?

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Aug 7, 2019

Re-tested it in Brave Release, (thanks Jimmy for the login).

https://secure.fanboy.co.nz/gif/udemy.gif

Seems to work

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Aug 7, 2019

I did notice 3rd-party device recognition being hit, does allowing all devices help?

@rebron rebron moved this from To do to P4 backlog in Web Compatibility Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Web Compatibility
  
P4 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.