Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start page is shown as new tab in shields #56

Closed
srirambv opened this issue Jan 16, 2018 · 4 comments
Closed

Start page is shown as new tab in shields #56

srirambv opened this issue Jan 16, 2018 · 4 comments
Assignees
@cezaraugusto
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes feature/shields
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 16, 2018

Clean install brave
Click continue on the start page which opens up Google.com
Click on shields, page title shows as newtab
image
@bbondy
Copy link
Member

@bbondy bbondy commented Jan 20, 2018

@srirambv what's expected for this case?
@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Jan 23, 2018 •
edited

@bbondy there are two things

  1. URL is missing which should be https://www.google.co.in/?gfe_rd=cr&dcr=0&ei=6bNmWsDtCNCBqAGGpKiACA (would change according to the region but should be the google home page)
  2. Since its the google homepage that is loaded, shields should show domain as google.com and not newtab
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #56 from brave/fix/92
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
118d436 
fix Linux build, GetDefaultUserDataDirectory issue, fix brave/brave#92
@bbondy bbondy added this to Nejc Zdovc in 0.55.x - Release Jun 6, 2018
@bbondy bbondy moved this from Nejc Zdovc to Pete Miller in 0.55.x - Release Jun 6, 2018
@bbondy bbondy moved this from Pete Miller to Cezar Augusto in 0.55.x - Release Jun 6, 2018
@bbondy bbondy added this to the Milestone 3: June-July milestone Jun 6, 2018
@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Jun 12, 2018

This looks fixed on c84b457. Not seeing the google launch page on start.
@srirambv srirambv closed this Jun 12, 2018
@bbondy bbondy removed this from Cezar Augusto in 0.55.x - Release Jun 13, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Aug 28, 2018 •
edited by kjozwiak

Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
@kjozwiak kjozwiak added QA Pass-macOS and removed QA/Yes labels Sep 25, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes feature/shields
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@bbondy @kjozwiak @cezaraugusto @srirambv @GeetaSarvadnya
You can’t perform that action at this time.