Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta issue for supporting multi channel install on MacOS #562

Closed
simonhong opened this issue Jul 17, 2018 · 4 comments
Closed

Meta issue for supporting multi channel install on MacOS #562

simonhong opened this issue Jul 17, 2018 · 4 comments
Assignees
@simonhong
Labels
OS/macOS QA/No
Milestone
0.55.x - Release ...

Comments

@simonhong
Copy link
Collaborator

@simonhong simonhong commented Jul 17, 2018 •
edited

  • Support branding_path_component (#153)
  • Enable multi channel install (#469)

To support multi-channel we should have different BRANDING file for different channel.
Other platforms already support multi channel install.
@simonhong simonhong self-assigned this Jul 17, 2018
@bbondy bbondy added this to the Releasable builds milestone Jul 26, 2018
@bbondy bbondy added this to Simon Hong in 0.55.x - Release Jul 30, 2018
@simonhong
Copy link
Collaborator Author

@simonhong simonhong commented Aug 10, 2018

I completed multi channel install on MacOS w/o branding_patch_component.
@simonhong simonhong closed this Aug 10, 2018
@bbondy bbondy added the QA/Yes label Aug 17, 2018
@bbondy bbondy removed this from Simon Hong in 0.55.x - Release Aug 18, 2018
@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Oct 3, 2018

@simonhong is the testing done for #469 sufficient for this issue as well? cc @kjozwiak
@simonhong
Copy link
Collaborator Author

@simonhong simonhong commented Oct 3, 2018

@LaurenWags Yep, I think you can ignore this issue. #469 is sufficient.
@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Oct 3, 2018
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Oct 3, 2018

Labelling as QA/No as this was basically tested under #469 as @LaurenWags mentioned above. 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/macOS QA/No
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@bbondy @kjozwiak @simonhong @LaurenWags @btlechowski
You can’t perform that action at this time.