Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter Tips and Vimium #5670

Open
jonathansampson opened this issue Aug 15, 2019 · 2 comments
Open

Twitter Tips and Vimium #5670

jonathansampson opened this issue Aug 15, 2019 · 2 comments

Comments

@jonathansampson
Copy link

@jonathansampson jonathansampson commented Aug 15, 2019

Description

Vimium is incapable of finding the Twitter Tip buttons.

Steps to Reproduce

  1. Install Vimium
  2. Reveal local hints by pressing f

Actual result:

Tip buttons are not given a hint label.

Expected result:

Tip buttons are given a hint label.

Reproduces how often:

Always.

Brave version (brave://version info)

0.67.125

Other Additional Information:

Here is a small test to confirm the issue. Note that the container lacking a shadow DOM is properly labeled by Vimium when pressing f, while the other is not: https://jsfiddle.net/x6L9n287/

shadow-container

@jonathansampson
Copy link
Author

@jonathansampson jonathansampson commented Aug 15, 2019

The move here may be to work with Vimium to better understand the issue, and resolve from their end.

@agentofuser
Copy link

@agentofuser agentofuser commented Aug 15, 2019

Thank you for looking into this! I've also observed this on github tipping buttons, as expected.

@NejcZdovc NejcZdovc added this to New Issues in Rewards via automation Aug 19, 2019
@NejcZdovc NejcZdovc moved this from New Issues to Icebox in Rewards Sep 20, 2019
@NejcZdovc NejcZdovc added suggestion and removed priority/P5 labels Apr 10, 2020
@NejcZdovc NejcZdovc moved this from Icebox to Suggestion in Rewards Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Rewards
  
Suggestion
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.