Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greaselion scripts can't communicate with extensions #5674

Closed
pilgrim-brave opened this issue Aug 15, 2019 · 0 comments · Fixed by brave/brave-core#3124
Closed

Greaselion scripts can't communicate with extensions #5674

pilgrim-brave opened this issue Aug 15, 2019 · 0 comments · Fixed by brave/brave-core#3124
Assignees
@pilgrim-brave
Labels
dev-concern QA/No release-notes/exclude
Milestone
0.70.x - Release

Comments

@pilgrim-brave
Copy link

To support tipping on Twitter (and elsewhere), Greaselion scripts will need to communicate with extensions with a subset of the extension API (chrome.runtime.sendMessage at least). The current Greaselion architecture does not allow for this, because the isolated world in which we execute the scripts does not have the extension API available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
dev-concern QA/No release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Rewrite Greaselion around component extensions brave/brave-core
3 participants
@bsclifton @rebron @pilgrim-brave