Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import using account seed phrase broken link #5682

Closed
rebron opened this issue Aug 15, 2019 · 9 comments
Closed

import using account seed phrase broken link #5682

rebron opened this issue Aug 15, 2019 · 9 comments

Comments

@rebron
Copy link
Collaborator

@rebron rebron commented Aug 15, 2019

Description

Returning to brave://wallet can't use "import using account seed phrase"

Steps to Reproduce

  1. Go to brave://wallet
  2. Close browser and go back to brave://wallet (so you're logged out and see Welcome Back! screen)
  3. Click "Import using account seed phrase"
  4. Notice it takes you to a blank brave://wallet page.

Actual result:

Screen Shot 2019-08-15 at 11 27 46 AM
Screen Shot 2019-08-15 at 11 28 13 AM

Expected result:

Should take me to import flow.

Brave version (brave://version info)

Version 0.71.5 Chromium: 76.0.3809.100 (Official Build) nightly (64-bit)

@ryanml
Copy link
Member

@ryanml ryanml commented Aug 15, 2019

Note: Import is functional, just not from the path where you have already created an account

@rebron rebron changed the title import using account seed phrase not functional import using account seed phrase broken link Aug 15, 2019
@rebron rebron added this to Done in Crypto Wallets Aug 22, 2019
@kjozwiak kjozwiak added this to the 0.69.x - Release milestone Oct 2, 2019
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 2, 2019

Issue doesn't seem to be fixed. If I set device language to English and then follow the steps from original issue then clicking on it does nothing. Seems like a dead UI. But when i change locale to French and try the same steps it shows the recover seed page but fails to recover

@srirambv srirambv reopened this Oct 2, 2019
Crypto Wallets automation moved this from Done to In progress Oct 2, 2019
@kjozwiak kjozwiak removed this from the 0.69.x - Release milestone Oct 2, 2019
@kjozwiak kjozwiak moved this from In progress to To do in Crypto Wallets Oct 2, 2019
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Oct 2, 2019

@srirambv this seems to be working for me using the following STR:

  • load brave://wallet in a new profile (dismiss the disclosure)
  • select Restore which takes you to the Import an Account with Seed Phrase screen
  • paste your wallet seed and enter a new password --> Click Import
  • the Congratulations screen loads with some information
  • click on All Done and brave://wallet loads as expected

re: MM seeds not working, re-opened #5698

@rebron mind going through this as well? Is it working for you? Is the above the correct STR?

@rebron
Copy link
Collaborator Author

@rebron rebron commented Oct 3, 2019

This is working for me. Original issue is when coming back to brave://wallet, I selected 'Import account using seed phrase' and the page was blank. That was the issue that was hung up, didn't even have the option to recover my account via seed phrase.

This is what I'm getting now. And I was able to use the seed phrase to recover my account while creating a new password.
Screen Shot 2019-10-02 at 5 02 27 PM

Verified with:
Version 0.69.131 Chromium: 77.0.3865.90 macOS 10.15

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 3, 2019

Seems to be working for me as well now on both Windows and Linux. Closing and marking the issue as verified

@srirambv srirambv closed this Oct 3, 2019
Crypto Wallets automation moved this from To do to Done Oct 3, 2019
@kjozwiak kjozwiak added this to the 0.69.x - Release milestone Oct 3, 2019
@rebron rebron removed this from Done in Crypto Wallets Oct 29, 2019
@CMEONE
Copy link

@CMEONE CMEONE commented Nov 23, 2019

@rebron This isn't working anymore, so could you please reopen the issue? Here is what I have tried doing:

  1. Go to brave://wallet
  2. Click on "Restore account? Import using account seed phrase"
    It doesn't even redirect anywhere!
@paulwaldmann
Copy link

@paulwaldmann paulwaldmann commented Dec 29, 2019

Same for me, using Manjaro Linux and the latest Brave browser Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) unknown (64-bit), click on "Restore account? Import using account seed phrase" takes no effect.

Please reopen this issue!

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Dec 29, 2019

@paulwaldmann @CMEONE could one of you please log a new issue with the exact steps. This issue is already linked to a merged PR so won't be reopening. We can triage the new issue that will be logged

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 30, 2019

@CMEONE @paulwaldmann created an issue for you all here:
#7537

Please do add information that will help us troubleshoot 😄 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants
You can’t perform that action at this time.