Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site settings should have a way to be set to default (inherit from global) #5721

Open
bsclifton opened this issue Aug 19, 2019 · 2 comments
Open
Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave.
Projects

Comments

@bsclifton
Copy link
Member

Description

Issue raised by @bridiver:
If you modify the site settings, including changing them back... they are not updated when you modify the global settings

Steps to Reproduce

  1. Visit https://brave.com
  2. Open shields. Change cookies to Cookies blocked
  3. Change cookies back to Cross-site cookies blocked
  4. Visit brave://settings
  5. Update global default to Cookies blocked

Actual result:

Site setting for brave.com is retained as Cross-site cookies blocked

Expected result:

There should be an option (for the site) that says Default for when you don't care about the behavior, you just want to inherit the global settings

@bsclifton bsclifton added feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. labels Aug 19, 2019
@bridiver
Copy link
Contributor

other options include adding some kind of "reset" button or setting the value to the current default will automatically reset it

@bsclifton bsclifton added this to Untriaged / Incoming in Shields via automation Aug 19, 2019
@rebron rebron removed this from Untriaged / Incoming in Shields Aug 30, 2019
@bsclifton bsclifton mentioned this issue Sep 1, 2020
@urbenlegend
Copy link

Also running into this issue. I usually like to run Brave with global Tracker & Ad Blocking set to Standard and then set certain sites to Aggressive when they're particularly obnoxious on certain days. Afterwards, they don't obey the global shield defaults anymore and the only way to clear them is to clear Sites and Shield settings using Clear browsing data.

Providing a reset button or default options in the shields dropdown boxes would prevent confusion.

@bsclifton bsclifton added this to Untriaged / Incoming in Shields via automation Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave.
Projects
Shields
  
Untriaged / Incoming
Development

No branches or pull requests

3 participants