Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site settings should have a way to be set to default (inherit from global) #5721

Open
bsclifton opened this issue Aug 19, 2019 · 1 comment
Open

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 19, 2019

Description

Issue raised by @bridiver:
If you modify the site settings, including changing them back... they are not updated when you modify the global settings

Steps to Reproduce

  1. Visit https://brave.com
  2. Open shields. Change cookies to Cookies blocked
  3. Change cookies back to Cross-site cookies blocked
  4. Visit brave://settings
  5. Update global default to Cookies blocked

Actual result:

Site setting for brave.com is retained as Cross-site cookies blocked

Expected result:

There should be an option (for the site) that says Default for when you don't care about the behavior, you just want to inherit the global settings

@bridiver
Copy link
Collaborator

@bridiver bridiver commented Aug 19, 2019

other options include adding some kind of "reset" button or setting the value to the current default will automatically reset it

@bsclifton bsclifton added this to Untriaged / Incoming in Shields via automation Aug 19, 2019
@rebron rebron removed this from Untriaged / Incoming in Shields Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.