Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAfter upgrade `Block cross-site trackers` should be disabled when ads & trackers are allowed in 0.67.125 #5753
Comments
|
self-assigned and set as |
|
I did some investigation, and it doesn't seem to be an issue anymore in current channels, so I'm going to close this for now and set as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When I upgrade 0.67.125 to 0.68.131 without changing any global shield settings, the global shield settings for
Block cross-site trackersis enabled, when global shield settings forAds controlis changed toAllow ads & trackersin 0.67.125 after upgradeBlock cross-site trackersis still enabled, this should be disabled as blocking of ads and trackers is allowed in 0.67.125.After upgrade to 0.68.131, If I disable the
Block cross-site trackerssetting, there won't be any changes in the opened sites, ads and trackers are still allowed for all the sites. If I enable it again, then ads and trackers are blocked. Looks like UI (Visual) bug, functionality is working as expected.Steps to Reproduce
Allow ads & trackersBlock cross-site trackersstateBlock cross-site trackersis enabled instead of disablingActual result:
After upgrade
Block cross-site trackersis enabled when ads and trackers are allowed in 0.67.125Expected result:
After upgrade
Block cross-site trackersshould be disabled when ads & trackers are allowed in 0.67.125Reproduces how often:
Always
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
@brave/legacy_qa @karenkliu @cezaraugusto