Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallets Setup - local wallet description - text correction #5774

Closed
lukemulks opened this issue Aug 23, 2019 · 2 comments
Closed

Crypto Wallets Setup - local wallet description - text correction #5774

lukemulks opened this issue Aug 23, 2019 · 2 comments

Comments

@lukemulks
Copy link
Collaborator

@lukemulks lukemulks commented Aug 23, 2019

Description

There is a typo in the copy for the local wallet option in the Crypto Wallets setup (brave://wallet)

New Local Wallet
Create a new Brave local wallet to access dApps and store crypto and collectibles securely. Trade tokens annonymously with no trading fees

"annonymously" should be updated to: anonymously
.

Steps to Reproduce

  1. from a clean profile, navigate to brave://wallet/
  2. locate local wallet option
  3. annonymously appears in the second sentence of local wallet description copy.

Actual result:

Expected result:

anonymously

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 0.70.72 
Chromium: 76.0.3809.100 (Official Build) dev (64-bit)
-- | --
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Windows 10 OS 
Version 1803 (Build 17134.950)

Version/Channel Information:

  • Can you reproduce this issue with the current release? unknown
  • Can you reproduce this issue with the beta channel? unknown
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bbondy
Copy link
Member

@bbondy bbondy commented Aug 23, 2019

Thanks I have this fixed with a PR for localizations I'm doing.

bbondy added a commit to brave/ethereum-remote-client that referenced this issue Aug 23, 2019
bbondy added a commit to brave/ethereum-remote-client that referenced this issue Aug 23, 2019
@rebron rebron added this to To do in Crypto Wallets via automation Aug 23, 2019
Crypto Wallets automation moved this from To do to Done Aug 23, 2019
@kjozwiak kjozwiak added this to the 0.69.x - Release milestone Oct 2, 2019
@kjozwiak kjozwiak added the QA/Yes label Oct 2, 2019
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 2, 2019

Verification passed on

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux
  • Verified misspelt word is corrected on component version 1.0.9
    image

Verification passed on

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1903 (Build 18362.30)
  • Verified misspelt word is corrected on component version 1.0.9
    image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Used Crypto Wallets - Version: 1.0.9 and went through the following:

Screen Shot 2019-10-02 at 7 41 45 PM

@rebron rebron removed this from Done in Crypto Wallets Oct 29, 2019
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.