Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Chrome" browser references in brave://about page #5775

Open
lukemulks opened this issue Aug 23, 2019 · 6 comments
Open

"Chrome" browser references in brave://about page #5775

lukemulks opened this issue Aug 23, 2019 · 6 comments

Comments

@lukemulks
Copy link
Collaborator

@lukemulks lukemulks commented Aug 23, 2019

Description

"Chrome" is displayed for all of the URLs and browser references within the brave://about page

Steps to Reproduce

  1. navigate to brave://about
  2. observe Chrome used in the page, title, tab and urls

Actual result:

Expected result:

All instances of "Chrome" should be replaced with "Brave"

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 0.70.72 
Chromium: 76.0.3809.100 (Official Build) dev (64-bit)
-- | --
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Windows 10 
OS Version 1803 (Build 17134.950)

Version/Channel Information:

  • Can you reproduce this issue with the current release? unknown
  • Can you reproduce this issue with the beta channel? unknown
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@lukemulks
Copy link
Collaborator Author

@lukemulks lukemulks commented Aug 23, 2019

@rebron assigned you on this one - suspect you'd likely know the best path forward in queue.

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 11, 2019

+1 from @bershanskiy via #6438

@bsclifton bsclifton added the branding label Oct 11, 2019
@bershanskiy
Copy link

@bershanskiy bershanskiy commented Oct 11, 2019

@srirambv Thank you for closing my duplicate.

@bershanskiy
Copy link

@bershanskiy bershanskiy commented Oct 11, 2019

@rebron Have you started working on this yet? If not, may I make a PR and tag you on it?

@rebron rebron removed their assignment Oct 11, 2019
@rebron
Copy link
Collaborator

@rebron rebron commented Oct 11, 2019

@bershanskiy go ahead and grab, that would be great.

@aussiechief
Copy link

@aussiechief aussiechief commented Nov 13, 2019

While just cosmetic, this is also the case in brave://settings, brave://rewards, brave://history, brave://bookmarks, brave://downloads, etc. All cross-referencing links are still using the chrome:// protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Front End
  
P5 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants
You can’t perform that action at this time.