Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check all version related file when builds #579

Open
simonhong opened this issue Jul 18, 2018 · 1 comment
Open

Check all version related file when builds #579

simonhong opened this issue Jul 18, 2018 · 1 comment

Comments

@simonhong
Copy link
Collaborator

@simonhong simonhong commented Jul 18, 2018 •
edited

brave-browser/package.json, chrome/VERSION and brave-core/package.json
All these files must use same brave version.

If they have different value, unexpected behavior will be happened. (ex, install)

I think using more than one file is error prone.
This was referenced Jul 18, 2018
Merged
Merged
@bbondy
Copy link
Member

@bbondy bbondy commented Jul 26, 2018

We're going to stop using brave-core/package.json and just keep it at 0.0.1
@bbondy bbondy added this to the Backlog milestone Jul 26, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@bbondy @rebron @simonhong
You can’t perform that action at this time.