Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromium WebUI buttons are over-eagerly re-styled for brave style #5977

Closed
petemill opened this issue Sep 10, 2019 · 1 comment
Closed

Chromium WebUI buttons are over-eagerly re-styled for brave style #5977

petemill opened this issue Sep 10, 2019 · 1 comment
Assignees
@petemill
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Test-Plan-Specified QA/Yes priority/P3 release-notes/exclude
Milestone
0.70.x - Release

Comments

@petemill
Copy link
Member

@petemill petemill commented Sep 10, 2019

Our c77 rebase includes a new technique for re-styling chromium's buttons which now affect every button, not just in the components that are pre-decided.

The negative side-effect of this is that there are other instances of the button element which don't actually look like buttons, such as avatars:

image

Description

Steps to Reproduce

  1. Open chrome://settings
  2. Click 'Profile name and icon'

Actual result:

Rounded squares and image disappears on hover

Expected result:

Circles with no hover effect

Reproduces how often:

100%

Brave version (brave://version info)

70, 71, 72 with c77
@petemill petemill self-assigned this Sep 10, 2019
@rebron rebron added this to Untriaged backlog in Settings Sep 10, 2019
@rebron rebron added this to P1 & P2 backlog in Front End Sep 17, 2019
@rebron rebron moved this from Untriaged backlog to P3 backlog in Settings Sep 23, 2019
@rebron rebron added the priority/P3 label Sep 23, 2019
@rebron rebron removed this from P3 backlog in Settings Sep 23, 2019
@petemill petemill mentioned this issue Oct 1, 2019
Merged
14 of 32 tasks complete
@rebron rebron moved this from P1 & P2 backlog to In progress in Front End Oct 1, 2019
@bsclifton bsclifton added this to the 0.72.x - Nightly milestone Oct 2, 2019
This was referenced Oct 3, 2019
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Oct 7, 2019
Closed
@rebron rebron moved this from In progress to Completed in Front End Oct 8, 2019
@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Oct 8, 2019 •
edited by btlechowski

Verified passed with

Brave 0.70.110 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Screen Shot 2019-10-08 at 3 56 16 PM

Verification passed on

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description
    image

Verification passed on

Brave 0.70.111 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS
  • Verified STR from the description
    image
@rebron rebron removed this from Completed in Front End Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Test-Plan-Specified QA/Yes priority/P3 release-notes/exclude
Projects
None yet
Milestone
  0.70.x - Release
Linked pull requests

Successfully merging a pull request may close this issue.

Fix profile avatars getting button style overrides instead of avatar circles
6 participants
@petemill @bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya
You can’t perform that action at this time.