Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override .cc files completely #60

Closed
bbondy opened this issue Jan 20, 2018 · 0 comments
Closed

Ability to override .cc files completely #60

bbondy opened this issue Jan 20, 2018 · 0 comments
Assignees
Labels

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Jan 20, 2018

We have the ability to override .h files via the include search path but not the .cc files currently.
For any .cc file that exists in chromium_src subdir, we should use it instead of the src chrome verison of it.

  • Override the paths if the path exists using a python script and with cc_wrapper.
  • Remove the patches we have with .cc overrides and use this instead.
@bbondy bbondy closed this Mar 1, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
Upload Brave QA builds to a new private repo
@bbondy bbondy added this to the Releasable builds milestone Jun 14, 2018
@bbondy bbondy added the QA/No label Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.