Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Shields Settings restyle #606

Closed
jumde opened this issue Jul 19, 2018 · 6 comments
Closed

Global Shields Settings restyle #606

jumde opened this issue Jul 19, 2018 · 6 comments
Assignees
@tomlowenthal @petemill @rebron @rossmoody
Labels
closed/invalid design feature/global-settings feature/shields stale
Milestone
Dupe / Invalid / ...

Comments

@jumde
Copy link
Contributor

@jumde jumde commented Jul 19, 2018

Shield settings are available per site as of now.
@jumde jumde added the audit-release label Jul 19, 2018
@bbondy bbondy added this to the Releasable builds milestone Jul 26, 2018
@jumde jumde added this to Release channel blockers in Security & Privacy Jul 26, 2018
@bbondy bbondy added this to Pranjal Jumde in 0.55.x - Release Jul 30, 2018
@jumde
Copy link
Contributor Author

@jumde jumde commented Aug 16, 2018

This is available in browser-laptop
@rebron
Copy link
Collaborator

@rebron rebron commented Sep 7, 2018

global-shield-settings

See #955 for placement
@rebron
Copy link
Collaborator

@rebron rebron commented Sep 7, 2018

site-permissions

For Site permissions, moving parts of content settings into this section.
@rebron
Copy link
Collaborator

@rebron rebron commented Sep 7, 2018

allow-block-list

Allow and Block list.
@rebron rebron mentioned this issue Sep 20, 2018
Closed
@bbondy bbondy changed the title Global Shield Settings Global Shield Settings front end Sep 22, 2018
@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 Sep 26, 2018
@bbondy
Copy link
Member

@bbondy bbondy commented Sep 26, 2018

Moved to 1.0 because we have the functionality for global shields available here with existing looking settings UI: #1288

I think we could probably move this even past 1.0 if needed because of timing.
@bbondy bbondy mentioned this issue Sep 26, 2018
Closed
@bbondy bbondy modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Sep 28, 2018
@bbondy bbondy removed this from Release channel blockers in Security & Privacy Sep 28, 2018
@bbondy bbondy removed the audit-release label Sep 28, 2018
@bbondy bbondy added this to Settings and chrome:// pages in 1.0 Tasks by Category Sep 29, 2018
@bbondy bbondy removed this from Security in 0.55.x - Release Sep 30, 2018
@rebron rebron mentioned this issue Sep 30, 2018
Open
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@bsclifton bsclifton changed the title Global Shield Settings front end Global Shields Settings restyle Oct 30, 2018
@bsclifton bsclifton mentioned this issue Oct 30, 2018
Closed
@rebron rebron added priority/P2 and removed priority/P3 labels Jan 15, 2019
@rebron rebron moved this from P3, P4 backlog to P1 & P2 Backlog in Settings Jan 15, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron assigned rebron, rossmoody and tomlowenthal and unassigned bsclifton Mar 14, 2019
@rebron rebron removed this from P1 & P2 Backlog in Settings Apr 16, 2019
@rebron
Copy link
Collaborator

@rebron rebron commented Apr 16, 2019

Closing in favor of newer design.
@rebron rebron closed this Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomlowenthal tomlowenthal

@petemill petemill

@rebron rebron

@rossmoody rossmoody

Labels
closed/invalid design feature/global-settings feature/shields stale
Projects
None yet
Milestone
  Dupe / Invalid / ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
@tomlowenthal @petemill @bbondy @jumde @bsclifton @rebron @NejcZdovc @rossmoody
You can’t perform that action at this time.