Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Crypto Wallets Injects Code? #6181

Closed
jonathansampson opened this issue Sep 26, 2019 · 2 comments · Fixed by brave/brave-core#3578

Comments

@jonathansampson
Copy link

@jonathansampson jonathansampson commented Sep 26, 2019

Description

Crypto Wallets is reportedly still injecting code into pages even when disabled. Other users were unable to reproduce the issue (https://twitter.com/GregJeanmart/status/1177222741239488514).

Steps to Reproduce

See #6181 (comment) below.

Actual result:

MetaMask detects injected code.

Expected result:

No code is injected when CryptoWallets is disabled.

Reproduces how often:

Always.

Brave version (brave://version info)

0.70.100 Chromium: 77.0.3865.90

Miscellaneous Information:

Reported on Twitter: https://twitter.com/bitfalls/status/1177219557712388104

image

@Swader

This comment has been minimized.

Copy link

@Swader Swader commented Sep 26, 2019

Version 0.70.100 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Windows.

  • Disable crypto wallets in settings
  • Visit web3 page
  • above error shows up.

Gif:

bravemm

@kjozwiak kjozwiak added this to To do in CryptoWallets via automation Sep 26, 2019
bbondy added a commit to brave/brave-core that referenced this issue Oct 2, 2019
@bbondy bbondy mentioned this issue Oct 2, 2019
10 of 32 tasks complete
bbondy added a commit to brave/brave-core that referenced this issue Oct 2, 2019
CryptoWallets automation moved this from To do to Done Oct 2, 2019
@kjozwiak

This comment has been minimized.

Copy link
Member

@kjozwiak kjozwiak commented Oct 3, 2019

@bbondy looks you'll need to restart the browser when disabling Brave Wallet. If Brave Wallet was enabled and you disable it but still have MM installed, you'll still get the following error as mentioned above:

Screen Shot 2019-10-03 at 4 31 11 AM

Once you restart the browser and refresh https://uniswap.exchange/swap, you'll get the following:

Screen Shot 2019-10-03 at 4 31 44 AM

@bbondy went through the above using 0.69.132 CR: 77.0.3865.90 which is the latest RC. However, I'm seeing the same behaviour with 0.69.131 CR: 77.0.3865.90 regarding restarting the browser so not really sure if this was really fixed. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.