Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet process isn't killed when Brave wallet is disabled in extensions until browser restart #6237

Open
srirambv opened this issue Sep 30, 2019 · 2 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 30, 2019

Description

Wallet process isn't killed when Brave wallet is disabled in extensions

Steps to Reproduce

  1. Click on Crypto Wallet to start the wallet process
  2. Disable Brave Wallet under extension
  3. Open a new tab and visit brave://wallet, shows error page
  4. Open browser task manager, Wallet process is still running even though its disabled under extension

Actual result:

image

Expected result:

Should kill the process if the extension is disabled

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @ryanml @bbondy

@bbondy

This comment has been minimized.

Copy link
Member

@bbondy bbondy commented Oct 2, 2019

future restarts don't show it though, so probably not a big deal that we sit on this one for a bit.

@kjozwiak

This comment has been minimized.

Copy link
Member

@kjozwiak kjozwiak commented Oct 7, 2019

@bbondy assuming this is the same as per our earlier conversation regarding MM detecting Crypto Wallets even after disabling which causes #6181? Double checking before creating a new issue.

@bbondy bbondy changed the title Wallet process isn't killed when Brave wallet is disabled in extensions Wallet process isn't killed when Brave wallet is disabled in extensions until browser restart Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.