Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated text isn't constrained inside button #6290

Open
srirambv opened this issue Oct 2, 2019 · 0 comments
Open

Translated text isn't constrained inside button #6290

srirambv opened this issue Oct 2, 2019 · 0 comments
Labels
Chromium/waiting upstream QA/Yes feature/crypto-wallets l10n priority/P4 release-notes/exclude release/not-blocking
Projects
Crypto Wallets Chromium Rebasing

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 2, 2019

Description

The translated text isn't constrained inside the button. This is an upstream bug. Found while testing #5686

Steps to Reproduce

  1. Set device locale to French
  2. Create a new profile and launch crypto wallet
  3. Custom text inside buttons are overflowing the button size

Actual result:

Remind me later
image
Backup now
image

Expected result:

All text should be contained inside the button

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:
@srirambv srirambv added this to To do in Crypto Wallets via automation Oct 2, 2019
@bbondy bbondy moved this from Untriaged to Backlog in Crypto Wallets Dec 20, 2019
@bbondy bbondy added the priority/P4 label Dec 20, 2019
@bsclifton bsclifton added this to Waiting for upstream to fix in Chromium Rebasing Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Chromium/waiting upstream QA/Yes feature/crypto-wallets l10n priority/P4 release-notes/exclude release/not-blocking
Projects
Crypto Wallets
  
Backlog
Chromium Rebasing
  
Waiting for upstream to fix
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bbondy @srirambv
You can’t perform that action at this time.